Skip to content

Conversation

maurycy
Copy link
Contributor

@maurycy maurycy commented Sep 4, 2025

This is a quick follow up to #405.

The focus of #405 was adding pre-commit, ruff check and Github action, without doing too many changes in the code.

This PR finishes the uvx ruff check checks, except E501, as discussed in:

#405 (comment)

The PR is much shorted than expected because we excluded the benchmarks without updating the initial ignore:

https://github.com/python/pyperformance/blob/main/.pre-commit-config.yaml#L8

@maurycy maurycy changed the title ruff linter: remove all ignores except E501 Remove all ruff ignore except E501 Sep 4, 2025
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In the pre-commit config, let's also remove exclude: ^pyperformance/data-files/ from each of the hooks and have a single top-level one:

https://pre-commit.com/#pre-commit-configyaml---top-level

@hugovk hugovk merged commit 7d17d71 into python:main Sep 4, 2025
20 checks passed
@maurycy maurycy deleted the ruff-check-ignore-less branch September 4, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants