Skip to content

Use a relative exclude-paths in dependabot.yml and a wildcard #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2025
Merged

Use a relative exclude-paths in dependabot.yml and a wildcard #409

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c855f8d
change root, wildcard
maurycy Sep 5, 2025
8042826
no longer needed
maurycy Sep 5, 2025
716f9bf
Revert "no longer needed"
maurycy Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
version: 2
updates:
- package-ecosystem: "pip"
directory: "/pyperformance/requirements"
directory: "/"
exclude-paths:
- "pyperformance/data-files/"
- "pyperformance/data-files/**"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting.. The previous version should have worked as well. May be some regression in how Dependabot is trying to filter paths @hugovk

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One idea is to enable Dependabot in your fork, and then you can iterate more quickly to find a solution? (If there is one :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe this is working?

#411 is an expected update in the top-level pyproject.toml

Copy link
Contributor Author

@maurycy maurycy Sep 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk Thank you for a quick review. Great idea!

🤞 for now.

@dnlfm Maybe it's the relative path?

https://github.com/python/pyperformance/pull/409/files#diff-dd4fbda47e51f1e35defb9275a9cd9c212ecde0b870cba89ddaaae65c5f3cd28R4

Copy link

@dnlfm dnlfm Sep 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah..
I'm not an official maintainer of Dependabot - I just contributed in this file-fetching part, so I can't say in an accurate way what could be the real issue... Right now the logic has been moved away from the FileFetcher, so it could be because of the value of directory, making the exclude-paths relative to it.

Before, it would be relative to the root of the project. I'm not sure if the value for directory forces the "root" be another one (it might be)

schedule:
interval: "monthly"
Loading