Skip to content

Conversation

maurycy
Copy link
Contributor

@maurycy maurycy commented Sep 5, 2025

This should be the last one from this series:

#405 (comment)

@maurycy maurycy changed the title ruff format Add ruff format to pre-commit, run it, except the benchmarks Sep 5, 2025
@maurycy
Copy link
Contributor Author

maurycy commented Sep 5, 2025

@hugovk Did you review and not submit? Not pushing in any way. I see nothing here but you were active and there's "Apply suggestions" label on "My work" tab:

image

@hugovk
Copy link
Member

hugovk commented Sep 8, 2025

Yes, I started a review but didn't finish yet :)

Interesting GH says there are suggestions when they're not visible or actionable yet.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add these rules:

  "I",      # isort
  "ISC",    # flake8-implicit-str-concat
  "RUF022", # unsorted-dunder-all
  "RUF100", # unused noqa (yesqa)

Copy link
Contributor Author

@maurycy maurycy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk

Thank you for a great and careful review!

I've addressed all the comments. Also, I ensured that the GitHub Action and .pre-commit-config.yaml use the latest plugins.

Is there are any list of recommended Ruff rules? For example, RUF022 is not particularly popular. Generally, which projects have the most referential pyproject.toml?

@maurycy maurycy requested a review from hugovk September 8, 2025 21:18
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there are any list of recommended Ruff rules?

Not really.

For example, RUF022 is not particularly popular. Generally, which projects have the most referential pyproject.toml?

Of those linked, I help maintain cherry-picker and python-docs-theme.

maurycy and others added 3 commits September 11, 2025 17:38
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@maurycy maurycy requested a review from hugovk September 11, 2025 18:55
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll leave this a bit to see if anyone else has suggestions.

@hugovk
Copy link
Member

hugovk commented Sep 22, 2025

10 days is long enough, let's merge. Thanks!

@hugovk hugovk merged commit 553aa5d into python:main Sep 22, 2025
20 checks passed
@maurycy maurycy deleted the ruff-format branch September 22, 2025 17:21
maurycy added a commit to maurycy/pyperformance that referenced this pull request Sep 22, 2025
* main:
  Add `ruff format` to pre-commit, run it, except the benchmarks (python#410)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants