-
-
Notifications
You must be signed in to change notification settings - Fork 195
Add ruff format
to pre-commit, run it, except the benchmarks
#410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ruff format
ruff format
to pre-commit, run it, except the benchmarks
@hugovk Did you review and not submit? Not pushing in any way. I see nothing here but you were active and there's "Apply suggestions" label on "My work" tab: ![]() |
Yes, I started a review but didn't finish yet :) Interesting GH says there are suggestions when they're not visible or actionable yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add these rules:
"I", # isort
"ISC", # flake8-implicit-str-concat
"RUF022", # unsorted-dunder-all
"RUF100", # unused noqa (yesqa)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for a great and careful review!
I've addressed all the comments. Also, I ensured that the GitHub Action and .pre-commit-config.yaml
use the latest plugins.
Is there are any list of recommended Ruff rules? For example, RUF022 is not particularly popular. Generally, which projects have the most referential pyproject.toml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there are any list of recommended Ruff rules?
Not really.
For example, RUF022 is not particularly popular. Generally, which projects have the most referential pyproject.toml?
Of those linked, I help maintain cherry-picker and python-docs-theme.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll leave this a bit to see if anyone else has suggestions.
10 days is long enough, let's merge. Thanks! |
* main: Add `ruff format` to pre-commit, run it, except the benchmarks (python#410)
This should be the last one from this series:
#405 (comment)