Skip to content

Prevent failure on missing Last-Translator field #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2025
Merged

Prevent failure on missing Last-Translator field #270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bfd6a1
Prevent failure on missing Last-Translator field
rffontenelle Sep 12, 2025
49c672f
Refactor to remove clunky double condition check
rffontenelle Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions scripts/generate_commit_msg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,13 @@ def generate_commit_msg():
entry.msgid not in old_entries
or old_entries[entry.msgid] != entry.msgstr
):
translator = new_po.metadata.get("Last-Translator")
translator = translator.split(",")[0].strip()
# Prevent failure on missing Last-Translator field.
# Transifex only adds Last-Translator if someone from
# the team translated. If it was uploaded by an account
# that is not in the team, this field will be missing.
translator = (
(new_po.metadata.get("Last-Translator") or "").split(",")[0].strip()
)
if translator:
translators.add(f"Co-Authored-By: {translator}")
break
Expand All @@ -79,7 +84,7 @@ def chdir(path: Path):
parser.add_argument(
"path",
type=Path,
nargs='?',
nargs="?",
default=".",
help="Path to the Git repository (default: current directory)",
)
Expand Down
Loading