Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate rst:23-29 #683 #722

Merged
merged 8 commits into from
Dec 10, 2023

Conversation

robinsonweng
Copy link
Contributor

rst:27 當中有個關於 coroutine 的簡寫 coro, 不確定要不要保留
rst:29 finalizing 一詞有的地方翻譯為終結, 有的地方翻譯為完成項, 不確定要怎翻譯

ref:
https://openhome.cc/Gossip/JavaEssence/Finalize.html
https://learn.microsoft.com/zh-tw/dotnet/csharp/programming-guide/classes-and-structs/finalizers

@ken71301 ken71301 changed the base branch from 3.12 to event-1125 November 25, 2023 08:45
@ken71301
Copy link
Collaborator

可以開一個discussioin~

Copy link
Collaborator

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Part 1

library/asyncio-runner.po Outdated Show resolved Hide resolved
@robinsonweng robinsonweng marked this pull request as ready for review November 25, 2023 10:58
@robinsonweng robinsonweng changed the title Draft: Translate rst:23-29 #683 Translate rst:23-29 #683 Nov 25, 2023
@mattwang44
Copy link
Collaborator

rebase

Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattwang44 mattwang44 merged commit ba491c5 into python:event-1125 Dec 10, 2023
1 check passed
mattwang44 pushed a commit that referenced this pull request Dec 18, 2023
@robinsonweng robinsonweng deleted the libary/asyncio-runner branch December 19, 2023 02:24
mattwang44 pushed a commit that referenced this pull request Jan 26, 2024
mattwang44 pushed a commit that referenced this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants