Overload bool.__new__ for Literal bools #10465
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Gobot1234
added a commit
to Gobot1234/mypy
that referenced
this pull request
Jul 15, 2023
srittau
added
the
status: deferred
Gobot1234
changed the title
|
Is there a way to see the projects this affects using mypy-primer using my mypy branch? |
The easiest way would be to temporarily push a commit to your mypy PR that makes these edits to |
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Jul 19, 2023
Gobot1234
changed the title
AlexWaygood
reviewed
Jul 19, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
python/mypy#15687 (comment) changes don't appear to be causing any problems |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Still waiting for python/mypy#15687. |
|
Diff from mypy_primer, showing the effect of this PR on open source code: colour (https://github.com/colour-science/colour)
+ colour/continuous/signal.py:835: error: Argument 1 to "bool" has incompatible type "numpy.bool[builtins.bool]"; expected "_Truthy" [arg-type]
+ colour/continuous/signal.py:835: note: Following member(s) of "numpy.bool[builtins.bool]" have conflicts:
+ colour/continuous/signal.py:835: note: Expected:
+ colour/continuous/signal.py:835: note: def __bool__(self) -> Literal[True]
+ colour/continuous/signal.py:835: note: Got:
+ colour/continuous/signal.py:835: note: def __bool__(self) -> bool
+ colour/colorimetry/spectrum.py:415: error: Argument 1 to "bool" has incompatible type "numpy.bool[builtins.bool]"; expected "_Truthy" [arg-type]
+ colour/colorimetry/spectrum.py:415: note: Following member(s) of "numpy.bool[builtins.bool]" have conflicts:
+ colour/colorimetry/spectrum.py:415: note: Expected:
+ colour/colorimetry/spectrum.py:415: note: def __bool__(self) -> Literal[True]
+ colour/colorimetry/spectrum.py:415: note: Got:
+ colour/colorimetry/spectrum.py:415: note: def __bool__(self) -> bool
|
ilevkivskyi
added a commit
to python/mypy
that referenced
this pull request
Oct 4, 2025
Unblocks python/typeshed#10465 --------- Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
|
Is there a way to run this with mypy dev? @srittau |
|
@Gobot1234 You could just temporarily change the mypy version in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by microsoft/pyright#5515
Closes #6069
Deferred because of: python/mypy#15687