Skip to content

Make all protocols' param names pos-only in codecs.pyi #10713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2023
Merged

Make all protocols' param names pos-only in codecs.pyi #10713

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0c1639
Make all protocols' param names pos-only in codecs.pyi
sobolevn Sep 15, 2023
c5c6906
Address review
sobolevn Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions stdlib/codecs.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,16 +78,16 @@ class _Stream(_WritableStream, _ReadableStream, Protocol): ...
# They were much more common in Python 2 than in Python 3.

class _Encoder(Protocol):
def __call__(self, input: str, errors: str = ...) -> tuple[bytes, int]: ... # signature of Codec().encode
def __call__(self, __input: str, __errors: str = ...) -> tuple[bytes, int]: ... # signature of Codec().encode

class _Decoder(Protocol):
def __call__(self, input: bytes, errors: str = ...) -> tuple[str, int]: ... # signature of Codec().decode
def __call__(self, __input: bytes, __errors: str = ...) -> tuple[str, int]: ... # signature of Codec().decode

class _StreamReader(Protocol):
def __call__(self, stream: _ReadableStream, errors: str = ...) -> StreamReader: ...
def __call__(self, __stream: _ReadableStream, __errors: str = ...) -> StreamReader: ...

class _StreamWriter(Protocol):
def __call__(self, stream: _WritableStream, errors: str = ...) -> StreamWriter: ...
def __call__(self, __stream: _WritableStream, __errors: str = ...) -> StreamWriter: ...

class _IncrementalEncoder(Protocol):
def __call__(self, errors: str = ...) -> IncrementalEncoder: ...
Expand Down