Add is_required / is_repeated properties to FieldDescriptor
#14703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this might require #14067 to land first? |
This comment has been minimized.
This comment has been minimized.
The stubsabot PR can't be merged as-is since there's API changes, but (the mypy_primer hits can be ignored -- those are flakes that will be fixed in the next mypy update) |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
@brianschubert / @Avasam let me know if there's anything else to do here now that #14707 landed. Thanks! |
stefanvanburen
deleted the
svanburen/add-missing-field-descriptor-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14702.