Refine the copy._SupportsReplace.__replace__ signature
#14786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Sep 26, 2025
There was a problem hiding this comment.
Thanks! I'm not totally sure I understand what this PR fixes. Would you be able to add a test case to https://github.com/python/typeshed/blob/main/stdlib/%40tests/test_cases/check_copy.py that fails on main?
Sure; added. |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (non-existent)*args: Anyand**kwargs: Anycan be avoided by relying on the LSP and removing them altogether, making it a bit less incorrect :)Well, I wasn't able to make it work with pyright for some reason. So the PR pivoted and now aims to add support for
__replace__methods that replaces values associated to generic type parameters.The
ParamSpecstuff felt to me like a more natural way of expressing this, but I'm also fine with restoring the previousAnyargs and kwargs in case anyone objects.