Allow __import__
to take None
for the fromlist parameter
#14790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's more accurate, given CPython bytecode often seems to pass None to fromlist instead of an empty tuple.
Rationale
https://docs.python.org/3/library/dis.html#opcode-IMPORT_NAME
Ergo, the LOAD_CONST (None) is being passed as the
fromlist
parameter, and has been passed since at least CPython 3.9 (maybe even earlier). I'm only showing a test via the dis cli and importing a single module, but the result should be replicable in other conditions.Plus, the implementation of
__import__
inimportlib
only checks truthiness of fromlist before treating it as populated, soNone
seems like a valid input when looking there too.