Skip to content

fix(types): cr_frame may be None #14802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2025
Merged

fix(types): cr_frame may be None #14802

merged 3 commits into from
Sep 30, 2025

Conversation

ashm-dev
Copy link
Contributor

Closes #14780

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ashm-dev
Copy link
Contributor Author

@srittau @sobolevn
Could you take a look at my PR when you have a chance?

sobolevn
sobolevn approved these changes Sep 28, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand it can only be None for 3.12+

@sobolevn sobolevn self-requested a review September 28, 2025 10:09
sobolevn
sobolevn requested changes Sep 28, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve is a misclick

@ashm-dev ashm-dev requested a review from sobolevn September 28, 2025 11:50
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed Sep 28, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau
srittau approved these changes Sep 30, 2025
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit 284acd4 into python:main Sep 30, 2025
63 checks passed
@ashm-dev ashm-dev deleted the gh-14780 branch September 30, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

@sobolevn sobolevn sobolevn approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

types.CoroutineType.cr_frame should be FrameType | None

4 participants

@ashm-dev @srittau @sobolevn @AlexWaygood