fix type.__or__
#14813
Merged
fix type.__or__
#14813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
KotlinIsland
force-pushed
the
type.__or__
branch
from
31978d9 to
ec37678
Compare
This comment has been minimized.
This comment has been minimized.
KotlinIsland
force-pushed
the
type.__or__
branch
from
b428dba to
65d9bbf
Compare
This comment has been minimized.
This comment has been minimized.
KotlinIsland
force-pushed
the
type.__or__
branch
from
65d9bbf to
3bfe027
Compare
This comment has been minimized.
This comment has been minimized.
AlexWaygood
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Thanks! I think in this case the test wasn't particularly helpful (so I removed it), as each type checker has its own special-casing for this kind of scenario, and anyway the signature here seems simple enough that it's easy to see why it is the way it is if there's a comment in the source code
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int | intis notUnionType