Skip to content

Fix signature of asyncio.create_server. #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2019
Merged

Fix signature of asyncio.create_server. #2763

merged 1 commit into from
Feb 9, 2019

Conversation

aaugustin
Copy link
Contributor

  • host may be None to bind to all interfaces.
  • If sock is given, host and port shouldn't be specified.

@aaugustin
Fix signature of asyncio.create_server.
c0ba570 
* host may be None to bind to all interfaces.
* If sock is given, host and port shouldn't be specified.
@srittau
Copy link
Collaborator

srittau commented Feb 9, 2019

Restarting CI, since it seems the travis failure was not related to this PR.

srittau
srittau approved these changes Feb 9, 2019
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. Good use of an overload.

@srittau srittau merged commit 503cbb9 into python:master Feb 9, 2019
@aaugustin aaugustin mentioned this pull request Feb 23, 2019
Merged
@aaugustin aaugustin deleted the asyncio-create-server branch February 24, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaugustin @srittau