Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signature of asyncio.create_server. #2763

Merged
merged 1 commit into from Feb 9, 2019

Conversation

Projects
None yet
2 participants
@aaugustin
Copy link
Contributor

commented Jan 23, 2019

  • host may be None to bind to all interfaces.
  • If sock is given, host and port shouldn't be specified.
Fix signature of asyncio.create_server.
* host may be None to bind to all interfaces.
* If sock is given, host and port shouldn't be specified.
@srittau

This comment has been minimized.

Copy link
Collaborator

commented Feb 9, 2019

Restarting CI, since it seems the travis failure was not related to this PR.

@srittau

srittau approved these changes Feb 9, 2019

Copy link
Collaborator

left a comment

Thank you for the pull request. Good use of an overload.

@srittau srittau merged commit 503cbb9 into python:master Feb 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aaugustin aaugustin deleted the aaugustin:asyncio-create-server branch Feb 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.