add colorsys #419
Merged
add colorsys #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Stubs for colorsys | ||
|
|
||
| from typing import Tuple | ||
|
|
There was a problem hiding this comment.
Please add the constants ONE_SIXTH, ONE_THIRD, TWO_THIRD. (All floats)
There was a problem hiding this comment.
These are undocumented, seems internal (not in __all__, nor having description); it was added in fc55ed0 if really wanted.
stdlib/2and3/colorsys.pyi
Outdated
| TWO_THIRD = ... # type: float | ||
|
|
||
| # TODO undocumented, should only work with float | ||
| def rgb_to_yiq(r: Union[float, complex], g: Union[float, complex], b: Union[float, complex]) -> Tuple[float, float, float]: ... |
There was a problem hiding this comment.
mypy allows you to use the shortcut complex for Union[float, complex], I think.
There was a problem hiding this comment.
Indeed, seems to work, updated in f9413c4.
hswong3i
pushed a commit
to alvistack/python-typeshed
that referenced
this pull request
May 25, 2025
Fixes python#419 Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anything more to say?