move stat.FILE_ATTRIBUTE_* to _stat.pyi and fix availability #6761
Conversation
Akuli
changed the title
Akuli
changed the title
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit b98ba39.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| IO_REPARSE_TAG_MOUNT_POINT: int | ||
| IO_REPARSE_TAG_APPEXECLINK: int | ||
|
|
||
| if sys.platform == "win32": |
There was a problem hiding this comment.
This is not true, I can use these values on macos
There was a problem hiding this comment.
I merged because a) Akuli did this intentionally (see comments in stubtest allowlists), b) they're documented as Windows only (https://docs.python.org/3/library/stat.html), c) there genuinely doesn't seem to be a use for them on other platforms and maybe that could uncover a bug.
That said, typeshed tries to avoid editorialising too much and we accomplish that by sticking close to implementation details, so if you (or anyone else) feel strongly or find this too opinionated I'm happy to have these definitions be unconditional.
There was a problem hiding this comment.
Ok, thanks for the explanation! I don't know when and why these values are used, so I don't have any strong opinions here 🙂
3 participants
No description provided.