Skip to content

Conversation

Akuli
Copy link
Collaborator

@Akuli Akuli commented Apr 27, 2022

#5779 (comment) shows code that uses this method. It works on 3.6, 3.7 and 3.8, but doesn't type-check without this PR on those versions.

Fixes #5779

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Akuli Akuli merged commit bfa9188 into python:master Apr 27, 2022
@Akuli Akuli deleted the asyncio-buflimits branch April 27, 2022 13:38
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood
Copy link
Member

https://docs.python.org/3/library/asyncio-protocol.html#asyncio.WriteTransport.get_write_buffer_limits says it was new in 3.4.2, not sure where we got 3.9 from.

It was a weird one where somebody noticed on BPO a few weeks ago that these had been documented forever, but not actually implemented in the code. So they were added the other week, and backported to 3.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad docs, or bad types for asyncio.WriteTransport?
3 participants