Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small error in create_line_strip #616

Closed
NielsOkker opened this issue Mar 22, 2020 · 3 comments
Closed

Small error in create_line_strip #616

NielsOkker opened this issue Mar 22, 2020 · 3 comments

Comments

@NielsOkker
Copy link

Dear arcade maintainers,

I noticed that only the final triangle of my line would be drawn on screen using 'create_line_strip' called with a line width bigger than 1. This appeared when I updated from version 2.1.3 to the current version, 2.3.8.

After investigating it appears that the return indenting has changed. It currently returns after the first triangle that it creates. It also seems to create a new shape for each triangle which also is not necessary.
https://github.com/pvcraven/arcade/blob/57ee9f04b3d7b456faf327f3c840058f870c67da/arcade/buffered_draw_commands.py#L218

Hoping to help,

Niels

@pvcraven pvcraven self-assigned this Mar 24, 2020
@pvcraven pvcraven added the bug label Mar 24, 2020
pvcraven added a commit that referenced this issue Mar 24, 2020
…add in unit test to catch the error in the future.
@pvcraven
Copy link
Member

Thanks for the detailed report.

@NielsOkker
Copy link
Author

Cool to see the fast fix! Thanks a lot.

@pvcraven
Copy link
Member

Arcade 2.3.9 is out, should be fixed now.
https://arcade.academy/release_notes.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants