-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing type hints #1720
Closed
Closed
Add missing type hints #1720
Changes from 1 commit
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
f9de04d
1st version
4cc412c
Add more Type Hints
2c4ecc8
Fix cspotcode's review
0d166e4
Add types to sprite.py
3076ed4
Try to fix some issues
97cb872
Fixed more github stuff
c3c590f
Fix easing.py somewhat
ffedb28
Mics changes bc tests are breaking
be086d0
.
06b6ddd
Changes bc git complained
171af9b
Fixes problems in 4 files
9623b62
Attempt to fix git again
a432ca6
type hint problems in property.py
5294ea1
attempts to fix property.py
5b0d1f0
I was misunderstanding the test error messages
211f6a2
.
3698b0f
Attempt to fix property
51a15eb
.
71ef4b2
.
7de2f68
Check changes in mixins.py
7873b18
Address no slots in View
f50d5e7
Partially added __slots__
4b3789d
Role back __slots__
8563913
.
18c7c2c
.
857ec84
Merge branch 'pythonarcade:development' into AddMissingTypeHints
gran4 8d4fdd0
(View)
98fe26e
Merge branch 'AddMissingTypeHints' of https://github.com/gran4/arcade…
545fde1
.
bfc4bc8
.
cb74764
.
3d52f73
.
5c6e5d6
.
f581cbf
.
2d44801
.
a2097f1
.
30b5b26
Add imports to mixins
9ee32fb
Change import in mixins
b8ab035
Fix shape_list.py
b17ffb5
Changed pyproject.toml as @pushfoo sugested
a2c6f5c
Revert pyproject change
f2ffcab
Add # type: ignore
b386371
Small errors fixed
9ba0c55
.
1ce4b19
Merge branch 'development' into AddMissingTypeHints
gran4 16cccf6
Update arcade/application.py
gran4 5a8e8fb
Update arcade/gui/property.py
gran4 60b6f3d
cspotcode's fixes
0034450
//
a81a701
Merge branch 'AddMissingTypeHints' of https://github.com/gran4/arcade…
1c0af3c
lol
93761b6
added future immport annotations
5fe6a23
Remove generics
7f6de70
Requested fixes
a3e51d4
correct import in application
a5a6fc7
Add # type: ignore to speed it up
58805a7
Line was too long
3e867fa
Fixes
971e8f5
Merge branch 'pythonarcade:development' into AddMissingTypeHints
gran4 29e8632
..
99595de
Merge branch 'AddMissingTypeHints' of https://github.com/gran4/arcade…
6a0a779
...
135f7ca
..
4b344bf
.
aeb3819
.
gran4 929d87f
.
gran4 eb1f7d7
.
gran4 53237fa
.
gran4 21f3a8b
.
gran4 bc472c2
Update draw_commands.py
gran4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is a needed improvement. If it works, this should be in another, separate PR.