Skip to content

clean up the code and make it more readable #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2021
Merged

clean up the code and make it more readable #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 0 additions & 79 deletions Caesar_Cipher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,92 +6,13 @@
shift = int(input("Type the shift number:\n"))


#
#
# def encrypt(text, shift):
# count_text = len(text)
# move = ''
#
# # Loop through len of text
# # for m in range(0, count_text):
# # Add the index value of the number 5 to move variable
# # move += alphabet[shift]
# # Increment the shift and add it to the index value
# # alphabet[shift] = alphabet[shift + 1]
# # Increment the shift value by one during the Loop
# # shift += 1
# #
# # print(move)
# # for loop for check the first letter in text variable in the alphabet list
# for check in alphabet:
# # check for the index of the first character in the newText variable
# if check == newText[0][0]:
# # get the index that match the first character of the newText
# getIndex = alphabet.index(check)
#
# print(getIndex)
# # Loop through the length of the text variable
# for count in range(0, count_text):
# # Increment the index value in the alphabet
# alphabet[getIndex] = alphabet[getIndex + 1]
# # Increment the index on each loop to move forward
# getIndex += 1
# # Add each character of the index to the move string variable
# move += alphabet[getIndex]
#
# print(move)
#
#
# encrypt(text=text, shift=shift)

# for l in range()
# alphabet[text] = alphabet[text + 1]
# shift += 1
#

# BETTER COPY/Solution

#
# def encrypt(text, shift):
# newEn = ''
# for count in text:
# en = alphabet.index(count) + shift
# getLen = len(alphabet)
# if en >= getLen:
# total = en - getLen
# fw = alphabet[total]
# newEn += fw
#
# else:
# newEn += alphabet[en]
#
# print(f"The encode text is {newEn}") # newEn)
#
#
# def decrypt(text, shift):
# deNew = ''
# for check in text:
# getDecry = alphabet.index(check) - shift
# deNew += alphabet[getDecry]
#
# print(f"The decoded text is {deNew}")
#
#
# if direction == "encode":
# encrypt(text=text, shift=shift)
# elif direction == "decode":
# decrypt(text=text, shift=shift)

# Combining all the function and statement to one function call

def caesar(text, shift, direction):
codeChar = ''
if direction == 'encode':
for me in text:
ch = alphabet.index(me) + shift
if ch > len(alphabet):
alpLeft = ch - len(alphabet)
# ch - len(alphabet)
codeChar += alphabet[alpLeft]
else:
codeChar += alphabet[ch]
Expand Down