Skip to content

Conversation

r41k0u
Copy link
Collaborator

@r41k0u r41k0u commented Oct 2, 2025

No description provided.

@r41k0u r41k0u requested a review from Copilot October 2, 2025 16:38
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the map calling convention by changing from function-style calls (last()) to direct attribute access (last) for BPF map operations. The main purpose is to align the map access pattern with the expected syntax for BPF map operations.

  • Updated map access syntax from last().method() to last.method() in example code
  • Added debug printing to track AST processing of map calls
  • Enhanced function assignment handling to support map method calls through attribute access

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
pythonbpf/maps/maps_pass.py Added debug print statement for AST dump tracking
pythonbpf/functions_pass.py Enhanced assignment handling to support map method calls via attribute access
examples/sys_sync.py Updated map calling convention from function calls to attribute access

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@r41k0u r41k0u marked this pull request as ready for review October 2, 2025 16:41
@r41k0u r41k0u merged commit 253944a into master Oct 2, 2025
1 check passed
@varun-r-mallya varun-r-mallya deleted the fix-maps branch October 8, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant