Skip to content

Conversation

r41k0u
Copy link
Collaborator

@r41k0u r41k0u commented Oct 2, 2025

No description provided.

@r41k0u
Copy link
Collaborator Author

r41k0u commented Oct 2, 2025

This takes care of the beautification stuff, now I can work on missing grammar

@r41k0u
Copy link
Collaborator Author

r41k0u commented Oct 3, 2025

This is mostly fixed, the next things I will do are outside the scope of this PR.

@r41k0u r41k0u marked this pull request as ready for review October 3, 2025 11:57
@r41k0u r41k0u requested a review from Copilot October 3, 2025 11:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors expression and binary operation handling by modularizing logic, simplifying function signatures, and expanding operand support; adjusts tests accordingly and changes default compile logging verbosity.

  • Extracted expression evaluation into helper functions and simplified binary op handling to return computed values.
  • Updated tests to use tracepoint section names and expanded a binary operation chain.
  • Changed default logging level for compile() from WARNING to INFO.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/passing_tests/binops1.py Modified test: changed section decorator, added print, and altered return value.
tests/passing_tests/binops.py Modified test to use longer chained binary expression.
pythonbpf/functions_pass.py Updated call to handle_binary_op to match new, reduced parameter list.
pythonbpf/expr_pass.py Refactored eval_expr into smaller helpers for names, constants, attributes, and deref calls.
pythonbpf/codegen.py Changed default log level of compile() to INFO (behavioral/API change).
pythonbpf/binary_ops.py Refactored binary op handling: added operand resolver, recursive support, and operation mapping.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@r41k0u r41k0u merged commit b351346 into master Oct 3, 2025
1 check passed
@varun-r-mallya varun-r-mallya deleted the fix-expr branch October 8, 2025 00:03
@varun-r-mallya varun-r-mallya moved this to In progress in TODOs Oct 8, 2025
@varun-r-mallya varun-r-mallya moved this from In progress to Done in TODOs Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant