-
Notifications
You must be signed in to change notification settings - Fork 3
Fix failing tests in tests/ #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We have fixed some binops tests and found grave issues with our typing system. I am in favour of merging this now, refactoring functions_pass and the grammar (so @varun-r-mallya can have a better time with vmlinux), and then coming back to this to fix our typing system and other issues. I have some ideas on how the typing system would be. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes failing tests in the test suite by addressing issues in the BPF compilation system, including function signature corrections, binary operation handling improvements, and default logging level adjustments.
Key changes:
- Fixed function signatures by removing unused
module
parameters from binary operation handlers - Enhanced return statement handling to support binary operations and variable references
- Changed default logging level from WARNING to INFO across compilation functions
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
tests/passing_tests/var_rval.py | New test file for variable assignment with binary operations |
tests/failing_tests/named_arg.py | New test file exposing typing system limitations with pointer operations |
tests/failing_tests/direct_assign.py | Updated map access calls and added explanatory comments about unsupported usage patterns |
pythonbpf/functions_pass.py | Fixed function calls, enhanced return statement handling, and corrected integer type sizes |
pythonbpf/codegen.py | Changed default logging level from WARNING to INFO |
pythonbpf/binary_ops.py | Removed unused module parameters and improved function signatures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.