Skip to content

Conversation

r41k0u
Copy link
Collaborator

@r41k0u r41k0u commented Oct 3, 2025

No description provided.

@r41k0u
Copy link
Collaborator Author

r41k0u commented Oct 5, 2025

We have fixed some binops tests and found grave issues with our typing system. I am in favour of merging this now, refactoring functions_pass and the grammar (so @varun-r-mallya can have a better time with vmlinux), and then coming back to this to fix our typing system and other issues. I have some ideas on how the typing system would be.

@r41k0u r41k0u marked this pull request as ready for review October 5, 2025 08:29
@r41k0u r41k0u requested a review from Copilot October 5, 2025 08:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes failing tests in the test suite by addressing issues in the BPF compilation system, including function signature corrections, binary operation handling improvements, and default logging level adjustments.

Key changes:

  • Fixed function signatures by removing unused module parameters from binary operation handlers
  • Enhanced return statement handling to support binary operations and variable references
  • Changed default logging level from WARNING to INFO across compilation functions

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/passing_tests/var_rval.py New test file for variable assignment with binary operations
tests/failing_tests/named_arg.py New test file exposing typing system limitations with pointer operations
tests/failing_tests/direct_assign.py Updated map access calls and added explanatory comments about unsupported usage patterns
pythonbpf/functions_pass.py Fixed function calls, enhanced return statement handling, and corrected integer type sizes
pythonbpf/codegen.py Changed default logging level from WARNING to INFO
pythonbpf/binary_ops.py Removed unused module parameters and improved function signatures

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@r41k0u r41k0u merged commit 552cd35 into master Oct 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants