Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support user level sql function #4

Closed
wants to merge 36 commits into from
Closed

Support user level sql function #4

wants to merge 36 commits into from

Conversation

pythonbrad
Copy link
Owner

CREATE FUNCTION hello() AS "SELECT 'hello!';";
CREATE FUNCTION add(x int) AS "SELECT x+1;";
CREATE FUNCTION div(int, int) AS "SELECT $1/$2;";

@pythonbrad pythonbrad changed the title Support user level sql function Support user level sql function [DRAFT] Feb 17, 2023
@coveralls
Copy link

coveralls commented Feb 17, 2023

Pull Request Test Coverage Report for Build 4651078690

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 731 of 764 (95.68%) changed or added relevant lines in 24 files are covered.
  • 33 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 98.615%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/ast/mod.rs 115 116 99.14%
core/src/executor/alter/function.rs 33 35 94.29%
core/src/executor/evaluate/mod.rs 35 38 92.11%
core/src/executor/execute.rs 16 19 84.21%
core/src/data/function.rs 7 11 63.64%
core/src/store/function.rs 0 20 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/executor/aggregate/mod.rs 7 82.9%
core/src/executor/evaluate/mod.rs 7 97.62%
core/src/executor/execute.rs 19 91.44%
Totals Coverage Status
Change from base Build 4635810229: -0.2%
Covered Lines: 35527
Relevant Lines: 36026

💛 - Coveralls

@pythonbrad pythonbrad marked this pull request as draft February 17, 2023 19:39
@pythonbrad pythonbrad changed the title Support user level sql function [DRAFT] Support user level sql function Feb 17, 2023
@pythonbrad pythonbrad force-pushed the patch_sql branch 3 times, most recently from 0cee14f to 0522471 Compare March 9, 2023 12:04
devgony and others added 2 commits April 7, 2023 17:40
Update `ToSql` to wrap table_name, column, index_name and identifier of expr with double quote.
Add `ToSqlUnquoted` trait.
Add unit tests for `TryFrom<&Value> for Decimal` in `data/value/convert.rs`
- renaming function trait and his method
- update show function
- update error
@pythonbrad pythonbrad closed this Apr 30, 2023
@pythonbrad pythonbrad deleted the patch_sql branch April 30, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants