Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure with python 3.7 #122

Closed
opoplawski opened this issue Jun 20, 2018 · 5 comments
Closed

Test failure with python 3.7 #122

opoplawski opened this issue Jun 20, 2018 · 5 comments

Comments

@opoplawski
Copy link

+ py.test-3.7 cytoolz
============================= test session starts ==============================
platform linux -- Python 3.7.0rc1, pytest-3.6.1, py-1.5.3, pluggy-0.6.0
rootdir: /builddir/build/BUILDROOT/python-cytoolz-0.9.0.1-1.fc29.x86_64/usr/lib64/python3.7/site-packages, inifile:
collected 190 items

=================================== FAILURES ===================================
_______________________ test_introspect_builtin_modules ________________________
    def test_introspect_builtin_modules():
        mods = [builtins, functools, itertools, operator, cytoolz,
                cytoolz.functoolz, cytoolz.itertoolz, cytoolz.dicttoolz, cytoolz.recipes]
    
        blacklist = set()
    
        def add_blacklist(mod, attr):
            if hasattr(mod, attr):
                blacklist.add(getattr(mod, attr))
    
        add_blacklist(builtins, 'basestring')
        add_blacklist(builtins, 'NoneType')
        add_blacklist(builtins, '__metaclass__')
        add_blacklist(builtins, 'sequenceiterator')
    
        def is_missing(modname, name, func):
            if name.startswith('_') and not name.startswith('__'):
                return False
            if name.startswith('__pyx_unpickle_') or name.endswith('_cython__'):
                return False
            try:
                if issubclass(func, BaseException):
                    return False
            except TypeError:
                pass
            try:
                return (callable(func)
                        and func.__module__ is not None
                        and modname in func.__module__
                        and is_partial_args(func, (), {}) is not True
                        and func not in blacklist)
            except AttributeError:
                return False
    
        missing = {}
        for mod in mods:
            modname = mod.__name__
            for name, func in vars(mod).items():
                if is_missing(modname, name, func):
                    if modname not in missing:
                        missing[modname] = []
                    missing[modname].append(name)
        if missing:
            messages = []
            for modname, names in sorted(missing.items()):
                msg = '{0}:\n    {1}'.format(modname, '\n    '.join(sorted(names)))
                messages.append(msg)
            message = 'Missing introspection for the following callables:\n\n'
>           raise AssertionError(message + '\n\n'.join(messages))
E           AssertionError: Missing introspection for the following callables:
E           
E           builtins:
E               breakpoint
cytoolz/tests/test_inspect_args.py:442: AssertionError
===================== 1 failed, 189 passed in 1.63 seconds =====================
@tillea
Copy link

tillea commented Dec 3, 2018

Any news for this issue? I stumbled upon this when trying to build a Debian package.

@tillea
Copy link

tillea commented Dec 6, 2018

Hi,
there was a patch submitted for the Debian package. Feel free to apply this upstream.
Hope this helps, Andreas.

akru added a commit to airalab/airapkgs that referenced this issue Dec 11, 2018
cytoolz has a test failure with Python 3.7 [0]. There is a debian patch
for it, which didn't make it into upstream yet [1].

[0] pytoolz/cytoolz#122
[1]
https://salsa.debian.org/python-team/modules/python-cytoolz/blob/master/debian/patches/py37.patch
erictapen added a commit to erictapen/nixpkgs that referenced this issue Dec 11, 2018
cytoolz has a test failure with Python 3.7 [0]. There is a debian patch
for it, which didn't make it into upstream yet [1].

[0] pytoolz/cytoolz#122
[1] https://salsa.debian.org/python-team/modules/python-cytoolz/raw/5ce4158deefc47475d1e76813f900e6c72ddcc6e/debian/patches/py37.patch
@eriknw
Copy link
Member

eriknw commented Jul 10, 2019

Better fix is here: pytoolz/toolz#454

Will release toolz and cytoolz shortly.

@eriknw eriknw closed this as completed Jul 10, 2019
@opoplawski
Copy link
Author

Thanks. 0.10.0 builds fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants