Skip to content

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Jun 7, 2021

Description

revert: downgrade Ignite to v0.4.4

ref: a0e9ce4

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

@ydcjeff ydcjeff requested review from vfdev-5 and trsvchn June 7, 2021 12:09
@netlify
Copy link

netlify bot commented Jun 7, 2021

✔️ Deploy Preview for code-generator ready!

🔨 Explore the source changes: 29f7cba

🔍 Inspect the deploy log: https://app.netlify.com/sites/code-generator/deploys/60c04c6b93e011000886e7d1

😎 Browse the preview: https://deploy-preview-157--code-generator.netlify.app/

@ydcjeff ydcjeff force-pushed the chore/down-ignite branch from 9b1cb2d to 29f7cba Compare June 9, 2021 05:06
@ydcjeff ydcjeff merged commit 2fbdce9 into main Jun 14, 2021
@ydcjeff ydcjeff deleted the chore/down-ignite branch June 14, 2021 18:15
@trsvchn
Copy link
Member

trsvchn commented Jun 17, 2021

This commit "Reverts downgrading to 0.4.4" or it "Downgrades to 0.4.4"? A little bit confusing

@trsvchn
Copy link
Member

trsvchn commented Jun 17, 2021

as far as I remember we decided to stick with nightly version until the 0.4.5 release with switching to 0.4.5 after it's release
am I right? @vfdev-5

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Jun 17, 2021

as far as I remember we decided to stick with nightly version until the 0.4.5 release with switching to 0.4.5 after it's release
am I right? @vfdev-5

Yes, we decided to stick with nightly version. But adding --pre in requirements.txt doesn't install nightly version. Adding --pre to install commands install nightly version of other requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants