Remove e5m2 from f8f8bf16_rowwise_batched #4908
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: facebookresearch/FBGEMM#1934 Fully remove this from f8f8bf16_rowwise_batched, we have already removed most of the kernel instances, this just cleans up the remaining one. Also moved some `TORCH_CHECK` into the main non-templated API level, as that would reduce some binary size (although likely trivial). Reviewed By: jiawenliu64 Differential Revision: D82976652
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request has been merged in 033bad0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1934
Fully remove this from f8f8bf16_rowwise_batched, we have already removed most of the kernel instances, this just cleans up the remaining one.
Also moved some
TORCH_CHECKinto the main non-templated API level, as that would reduce some binary size (although likely trivial).Reviewed By: jiawenliu64
Differential Revision: D82976652