Disable SWA related decode kernel tests since they are not supported #4911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@Alkaid-Benetnash has exported this pull request. If you are a Meta employee, you can view the originating diff in D82991496. |
|
@Alkaid-Benetnash has exported this pull request. If you are a Meta employee, you can view the originating diff in D82991496. |
Alkaid-Benetnash
force-pushed
the
export-D82991496
branch
from
8386574 to
83521aa
Compare
Alkaid-Benetnash
added a commit
to Alkaid-Benetnash/FBGEMM-1
that referenced
this pull request
Sep 23, 2025
Summary: Pull Request resolved: pytorch#4911 X-link: facebookresearch/FBGEMM#1936 D80992628 introduced SWA FWD kernel changes which did not support decode kernels (i.e., supporting sm100_fmha_fwd but not sm100_fmha_gen). Similarly, softmax_scale introduced in D82788784 did not support decode kernels either. In blackwell_fmha_test, the these parameters are dropped during decode kernel selection (https://www.internalfb.com/code/fbsource/[cd7066706035]/fbcode/deeplearning/fbgemm/fbgemm_gpu/experimental/gen_ai/test/attention/blackwell_fmha_test.py?lines=182) To avoid confusion, do not test test_decode with ignored parameters. Reviewed By: Aya-ZIbra, sryap Differential Revision: D82991496
Summary: X-link: facebookresearch/FBGEMM#1936 D80992628 introduced SWA FWD kernel changes which did not support decode kernels (i.e., supporting sm100_fmha_fwd but not sm100_fmha_gen). Similarly, softmax_scale introduced in D82788784 did not support decode kernels either. In blackwell_fmha_test, the these parameters are dropped during decode kernel selection (https://www.internalfb.com/code/fbsource/[cd7066706035]/fbcode/deeplearning/fbgemm/fbgemm_gpu/experimental/gen_ai/test/attention/blackwell_fmha_test.py?lines=182) To avoid confusion, do not test test_decode with ignored parameters. Reviewed By: Aya-ZIbra, sryap Differential Revision: D82991496
Alkaid-Benetnash
force-pushed
the
export-D82991496
branch
from
83521aa to
a14de4d
Compare
|
@Alkaid-Benetnash has exported this pull request. If you are a Meta employee, you can view the originating diff in D82991496. |
|
This pull request has been merged in 826064d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
D80992628 introduced SWA FWD kernel changes which did not support decode kernels (i.e., supporting sm100_fmha_fwd but not sm100_fmha_gen).
Similarly, softmax_scale introduced in D82788784 did not support decode kernels either.
In blackwell_fmha_test, the these parameters are dropped during decode kernel selection (https://www.internalfb.com/code/fbsource/[cd7066706035]/fbcode/deeplearning/fbgemm/fbgemm_gpu/experimental/gen_ai/test/attention/blackwell_fmha_test.py?lines=182)
To avoid confusion, do not test test_decode with ignored parameters.
Reviewed By: Aya-ZIbra, sryap
Differential Revision: D82991496