Skip to content

Use fbgemm_fml_flags and add fbgemm_sve guard #4948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Use fbgemm_fml_flags and add fbgemm_sve guard #4948

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b64e1d
Use fbgemm_fml_flags
cyyever Sep 30, 2025
8ae836b
Fix arm_neon_sve_bridge.h inclusion
cyyever Sep 30, 2025
84b96c5
Fix flags
cyyever Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ if(CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64|ARM64|arm64")
-ftree-vectorize
-fno-trapping-math
-Wignored-qualifiers
-march=armv8.2-a+fp16fml
${fbgemm_fml_flags}
DEFINITIONS
${fbgemm_arm_defs}
DEPS
Expand All @@ -337,7 +337,14 @@ endif()
################################################################################

set(FBGEMM_BUILD_SVE False)
if(CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64|ARM64")
# SVE and SVE2 feature paths require the intrinsics declared in arm_neon_sve_bridge.h
# This header file is available in the following releases:
# Clang 17 and later.
# GCC 14 and later.
if(CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64|ARM64" AND
((CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 14)
OR (CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 17)))

check_cxx_compiler_flag(-march=armv8-a+sve COMPILER_SUPPORTS_SVE)
check_cxx_compiler_flag(-march=armv8-a+sve2 COMPILER_SUPPORTS_SVE2)
if(COMPILER_SUPPORTS_SVE2)
Expand Down
Loading