Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nox): Replacing session with environment variable #1057

Merged
merged 2 commits into from
May 25, 2022

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented May 11, 2022

Signed-off-by: Anurag Dixit a.dixit91@gmail.com

Description

Reduced host dependency based sessions from nox lists.
Switched to environment variable based context switching. Reduces redundant sessions. We already have multiple sessions as per different Python versions.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
#1056

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
@andi4191 andi4191 added the component: tests Issues re: Tests label May 11, 2022
@andi4191 andi4191 requested a review from narendasan May 11, 2022 22:19
@andi4191 andi4191 self-assigned this May 11, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@andi4191
Copy link
Contributor Author

/blossom-ci

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add documentation to note that these env variables exist?

Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
@andi4191
Copy link
Contributor Author

Can you add documentation to note that these env variables exist?

@narendasan : Added documentation for the same.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@andi4191 andi4191 merged commit dcf3386 into master May 25, 2022
@andi4191 andi4191 deleted the anuragd/reduce_nox_sessions branch May 25, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants