chore: Apply linting and ignore new bazel dirs #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: api [Python]
andi4191
approved these changes
Aug 2, 2022
| @@ -124,13 +124,13 @@ ConversionCtx::ConversionCtx(BuilderSettings build_settings) | |||
| settings.enabled_precisions.find(nvinfer1::DataType::kFLOAT) == settings.enabled_precisions.end(), | |||
| "DLA supports only fp16 or int8 precision"); | |||
| cfg->setDLACore(settings.device.dla_core); | |||
| if (settings.dla_sram_size != 1048576){ | |||
| if (settings.dla_sram_size != 1048576) { | |||
There was a problem hiding this comment.
@narendasan : I see hard-coded values at multiple places. Can we move this to some macro definition instead?
There was a problem hiding this comment.
Sure thats fine, can you do this in a separate PR?
peri044
approved these changes
Aug 2, 2022
|
Python linter also runs fine (without hanging). However, python linter changes haven't been added to this PR. |
github-actions
bot
added
component: build system
narendasan
force-pushed
the
linter_updates
branch
from
28614c6
to
e495124
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- py/setup.py 2022-08-03 16:01:43.880250 +0000
+++ py/setup.py 2022-08-03 16:05:38.152933 +0000
@@ -26,14 +26,15 @@
RELEASE = False
CI_RELEASE = False
-__version__ = '1.2.0a0'
-__cuda_version__ = '11.3'
-__cudnn_version__ = '8.4'
-__tensorrt_version__ = '8.4'
+__version__ = "1.2.0a0"
+__cuda_version__ = "11.3"
+__cudnn_version__ = "8.4"
+__tensorrt_version__ = "8.4"
+
def get_git_revision_short_hash() -> str:
return subprocess.check_output(["git", "rev-parse", "--short", "HEAD"]).decode("ascii").strip()
narendasan
commented
Aug 3, 2022
third_party/tensorrt/local/BUILD
Outdated
| @@ -351,11 +351,6 @@ cc_library( | |||
| ":ci_rhel_x86_64_linux": glob(["lib64/libnvinfer_plugin.so"]), | |||
| "//conditions:default": ["lib/x86_64-linux-gnu/libnvinfer_plugin.so"], | |||
| }), | |||
| hdrs = select({ | |||
There was a problem hiding this comment.
Why did this get removed?
There was a problem hiding this comment.
There was a conflict with the base branch. I resolved it by replacing it with the ci_rhel_x86_64_linux version
This was referenced Aug 5, 2022
github-actions
bot
requested review from
842974287,
andi4191,
frank-wei,
peri044,
wushirong and
yinghai
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
linting Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
narendasan
force-pushed
the
linter_updates
branch
from
5700cd4
to
2f647f7
Compare
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
narendasan
force-pushed
the
linter_updates
branch
from
2f647f7
to
0ce172c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naren Dasan naren@narendasan.com
Signed-off-by: Naren Dasan narens@nvidia.com
Description
Fixing the linter speed
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: