Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct sha256sum of cudnn #1278

Merged
merged 1 commit into from
Aug 17, 2022
Merged

correct sha256sum of cudnn #1278

merged 1 commit into from
Aug 17, 2022

Conversation

Njuapp
Copy link
Contributor

@Njuapp Njuapp commented Aug 17, 2022

Description

The SHA256 and strip_prefix of cudnn in WORKSPACE file is incorrect, which causes compilation error.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added the component: build system Issues re: Build system label Aug 17, 2022
@Njuapp
Correct sha256sum and strip_prefix of cudnn
dd1993a 
Signed-off-by: Cheng Hang <calvinhance@gmail.com>
narendasan
narendasan approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 8929623 into pytorch:master Aug 17, 2022
@Njuapp Njuapp deleted the sha256 branch August 18, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@andi4191 andi4191 Awaiting requested review from andi4191

Assignees
No one assigned
Labels
cla signed component: build system Issues re: Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Njuapp @narendasan @facebook-github-bot