Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: torch.std and torch.var support multi-dimensional reductions #1395

Merged
merged 5 commits into from
Oct 12, 2022
Merged

fix: torch.std and torch.var support multi-dimensional reductions #1395

merged 5 commits into from
Oct 12, 2022

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Oct 8, 2022 •
edited

Description

Fixes bug where torch.var only supported single-dimension reductions when unbiased=True. Applied fix by changing how the bias correction is applied and avoiding the use of aten::select

Fixes #1182

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
Augment current tests to reproduce error generating bug with standard…
39246e6 
… dev / variance lowering
@gs-olive
fix: Ensure torch.std (and torch.var) support multiple dimensions
c65ef4e 
- Refactor IR code to avoid the use of select, for which only
single-dimension support exists currently
- Update formula in Bessel's correction (unbiased) case
- Include regression tests to catch multi-dimensional indexing errors
@github-actions github-actions bot added component: core Issues re: The core compiler component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests labels Oct 8, 2022
@gs-olive gs-olive changed the title fix: torch.std and torch.var support multi-dimensional reductions without erroring out fix: torch.std and torch.var support multi-dimensional reductions Oct 8, 2022
@narendasan narendasan marked this pull request as ready for review October 11, 2022 00:56
@narendasan narendasan merged commit 6bef925 into pytorch:master Oct 12, 2022
@gs-olive gs-olive deleted the multi_dim_var_bugfix branch October 12, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed component: core Issues re: The core compiler component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] torch.Tensor.std doesn't support multiple dimensions
3 participants
@gs-olive @narendasan @facebook-github-bot