feat(//core/partitioning) : Dynamic shapes + fallback #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
github-actions
bot
added
component: core
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
peri044
removed
the
WIP
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
|
Make strings like min, opt, max as enums |
… map in a PartioningCtx object Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/home/runner/work/TensorRT/TensorRT/core/compiler.cpp b/tmp/changes.txt
index d4c536a..58af1e6 100644
--- a/home/runner/work/TensorRT/TensorRT/core/compiler.cpp
+++ b/tmp/changes.txt
@@ -127,8 +127,6 @@ bool CheckMethodOperatorSupport(const torch::jit::script::Module& mod, std::stri
return conversion::VerifyConverterSupportForBlock(g->block());
}
-
-
partitioning::GraphAndMapping BuildHybridGraph(
torch::jit::script::Module& new_mod,
torch::jit::Block* block,
diff --git a/home/runner/work/TensorRT/TensorRT/core/partitioning/partitioning.cpp b/tmp/changes.txt
index 372489b..6e37afd 100644
--- a/home/runner/work/TensorRT/TensorRT/core/partitioning/partitioning.cpp
+++ b/tmp/changes.txt
@@ -450,17 +450,17 @@ bool isInputDynamic(PartitioningCtx* ctx) {
return input_is_dynamic;
}
-void populateInputIValues(PartitioningCtx* ctx){
+void populateInputIValues(PartitioningCtx* ctx) {
if (isInputDynamic(ctx)) {
- ctx->min_input_ivalues_map =
- partitioning::generateRandomInputs(ctx->settings.collection_input_spec_map, ctx->input_types_map, ir::ShapeMode::kMIN);
- ctx->opt_input_ivalues_map =
- partitioning::generateRandomInputs(ctx->settings.collection_input_spec_map, ctx->input_types_map, ir::ShapeMode::kOPT);
- ctx->max_input_ivalues_map =
- partitioning::generateRandomInputs(ctx->settings.collection_input_spec_map, ctx->input_types_map, ir::ShapeMode::kMAX);
+ ctx->min_input_ivalues_map = partitioning::generateRandomInputs(
+ ctx->settings.collection_input_spec_map, ctx->input_types_map, ir::ShapeMode::kMIN);
+ ctx->opt_input_ivalues_map = partitioning::generateRandomInputs(
+ ctx->settings.collection_input_spec_map, ctx->input_types_map, ir::ShapeMode::kOPT);
+ ctx->max_input_ivalues_map = partitioning::generateRandomInputs(
+ ctx->settings.collection_input_spec_map, ctx->input_types_map, ir::ShapeMode::kMAX);
} else {
- ctx->opt_input_ivalues_map =
- partitioning::generateRandomInputs(ctx->settings.collection_input_spec_map, ctx->input_types_map, ir::ShapeMode::kOPT);
+ ctx->opt_input_ivalues_map = partitioning::generateRandomInputs(
+ ctx->settings.collection_input_spec_map, ctx->input_types_map, ir::ShapeMode::kOPT);
}
}
diff --git a/home/runner/work/TensorRT/TensorRT/core/ir/ir.h b/tmp/changes.txt
index 91c2666..8e5e4cd 100644
--- a/home/runner/work/TensorRT/TensorRT/core/ir/ir.h
+++ b/tmp/changes.txt
@@ -12,9 +12,9 @@ namespace core {
namespace ir {
enum class ShapeMode {
- kMIN,
- kOPT,
- kMAX,
+ kMIN,
+ kOPT,
+ kMAX,
};
struct Input : torch::CustomClassHolder {
ERROR: Some files do not conform to style guidelinesSigned-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
|
Fixed merge conflicts with master due to recent merges. |
bowang007
reviewed
Nov 10, 2022
bowang007
approved these changes
Nov 13, 2022
bowang007
reviewed
Nov 13, 2022
bowang007
reviewed
Nov 13, 2022
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dynamic shapes + fallback. This is a refactor of #1111 (credits to @Njuapp).
Type of change
Checklist: