Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add functionality to performance tooling #1451

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

gs-olive
Copy link
Collaborator

Description

Improved performance tooling functionality to allow timing of additional code components and coalescing results for easy exporting

  • Add functionality for timing compilation in addition to inference
  • Add bash scripting code for concatenating all model result outputs

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
    • Tested manually on Docker container for verification
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive added the component: tooling Issues related to tooling label Nov 15, 2022
@narendasan narendasan removed their request for review November 15, 2022 20:29
- Add functionality for timing compilation in addition to inference
- Add bash scripting code for concatenating all model result outputs
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit e7bb8c2 into pytorch:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: tooling Issues related to tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants