Skip to content

feat: Support int inputs to aten::max/min and aten::argmax/argmin #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

feat: Support int inputs to aten::max/min and aten::argmax/argmin #1574

merged 1 commit into from
Jan 9, 2023

Conversation

mfeliz-cruise
Copy link
Contributor

@mfeliz-cruise mfeliz-cruise commented Jan 5, 2023 •
edited
Loading

Description

aten::max/min and aten::argmax/min currently error out with int inputs on the topk layer which only supports activation types. Add a cast to float to support int inputs.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests labels Jan 5, 2023
@mfeliz-cruise mfeliz-cruise changed the title [feat] Support int inputs to aten::max/min and aten::argmax/argmin feat: Support int inputs to aten::max/min and aten::argmax/argmin Jan 5, 2023
@mfeliz-cruise
Support int inputs to aten::max/min and aten::argmax/argmin by castin…
326de11 
…g to float (pytorch#94)

* Support int inputs to aten::max/min and aten::argmax/argmin by casting to float

* correct layer name

* address nit, remove local variable
@mfeliz-cruise mfeliz-cruise force-pushed the michael.feliz/max_int_input branch from 4afa72a to 326de11 Compare January 9, 2023 21:02
peri044
peri044 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 8adcacc into pytorch:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@bowang007 bowang007 Awaiting requested review from bowang007

@narendasan narendasan Awaiting requested review from narendasan

Assignees
No one assigned
Labels
cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfeliz-cruise @peri044 @facebook-github-bot