Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add schemas to convolution lowering pass #1728

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Mar 7, 2023

Description

  • Add support for transposed conv2d and conv3d
  • Add testing for all convolution functions, rename test accordingly

Since conv3d operations can generate and consume very large tensors, having a lowering pass to accommodate them can improve performance by decreasing graph segmentation.

Type of change

Please delete options that are not relevant and/or add your own.

  • Performance fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this Mar 7, 2023
@gs-olive gs-olive changed the title fix: Add schemas to conv replace fix: Add schemas to convolution lowering pass Mar 7, 2023
@github-actions github-actions bot added component: core Issues re: The core compiler component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests labels Mar 7, 2023
@github-actions github-actions bot requested a review from peri044 March 7, 2023 18:12
@gs-olive gs-olive added the WIP Work is in progress, pull request should not be merged yet label Mar 7, 2023
- Add support for transposed conv2d and conv3d, as well as for conv3d
- Add testing for all convolution functions, rename test accordingly
@gs-olive gs-olive removed the WIP Work is in progress, pull request should not be merged yet label Mar 8, 2023
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 83923ee into pytorch:main Mar 24, 2023
@gs-olive gs-olive deleted the add_convNd_lowering_ops branch March 24, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: core Issues re: The core compiler component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants