Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cherry-pick acc convolution fix to release/1.4 #1910

Merged
merged 1 commit into from
May 15, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

See #1886 for details

Type of change

  • PR Cherry-Pick

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
    • CI verification
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@github-actions github-actions bot requested a review from yinghai May 10, 2023 22:30
@gs-olive gs-olive removed the request for review from yinghai May 10, 2023 22:31
@gs-olive gs-olive added the release: v1.4 Tagged to be included in v1.4 label May 10, 2023
@github-actions github-actions bot requested a review from yinghai May 10, 2023 22:31
@gs-olive gs-olive removed the request for review from yinghai May 11, 2023 01:28
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 8dcb030 into release/1.4 May 15, 2023
15 checks passed
@gs-olive gs-olive deleted the acc_ops_release_update branch May 15, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: fx fx release: v1.4 Tagged to be included in v1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants