Pytorch 1.7 update API changes #225

peri044 · 2020-11-17T05:19:26Z

Description

Changes related to Pytorch 1.7 update

Fixes (#207)

Type of change

New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

My code follows the style guidelines of this project (You can use the linters)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas and hacks
I have made corresponding changes to the documentation
I have added tests to verify my fix or my feature
New and existing unit tests pass locally with my changes

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

narendasan · 2020-11-17T21:28:13Z

core/conversion/InterfaceTypes.cpp

@@ -11,7 +11,7 @@ GraphParams get_named_params(c10::ArrayRef<torch::jit::Value*> inputs, std::vect
  GraphParams named_params;
  auto param_it = params.begin();
  for (auto in : inputs) {
-    if (in->type() != c10::TensorType::get() && in->isCompleteTensor() && param_it != params.end()) {
+    if (in->type() != c10::TensorType::get() && param_it != params.end()) {


Did this end up being fixed?

Facing this error

Unexpected specifier 'strides':

Looks like the strides specifier did not make it into 1.7 branch. General branch stride support, 1.7 branch code comparison
From my understanding, the isCompleteTensor() doesn't seem to be absolutely necessary especially when we pass in constants to the graph assuming they have static shapes. The testcase usages don't absolutely need it.
Can you let me know if you have any other necessary usecases in mind where this would help ?
This definitely adds a extra layer of check which is good. I tried looking into pytorch 1.7 source and building it to understand why isCompleteTensor function changed, however that was blocked by some unrelated issues.

core/conversion/converters/impl/conv_deconv.cpp

narendasan · 2020-11-17T21:35:28Z

Bump this to 0.2.0 https://github.com/NVIDIA/TRTorch/blob/3ecf5d09fffce278c1df011878693aa21123ecad/cpp/api/include/trtorch/macros.h#L23

narendasan · 2020-11-17T21:36:51Z

Bump this to 0.2.0a0 https://github.com/NVIDIA/TRTorch/blob/4ee6c2023ec547ca579af53754fa2e1381189a10/py/setup.py#L19

and this to 1.7.0 https://github.com/NVIDIA/TRTorch/blob/4ee6c2023ec547ca579af53754fa2e1381189a10/py/setup.py#L207

narendasan · 2020-11-17T21:38:26Z

https://github.com/NVIDIA/TRTorch/blob/master/README.md#dependencies Can you update the dependency info here

narendasan · 2020-11-17T21:42:49Z

Can you bump up to the latest bazel version? https://github.com/NVIDIA/TRTorch/blob/master/.bazelversion

narendasan · 2020-11-17T21:43:59Z

https://github.com/NVIDIA/TRTorch/blob/pytorch_update/tests/py/requirements.txt bump to latest torchvision

narendasan · 2020-11-17T21:44:22Z

https://github.com/NVIDIA/TRTorch/blob/pytorch_update/py/requirements.txt bump to latest torch

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

narendasan · 2020-12-08T21:40:14Z

@peri044 was there anything outstanding on your side or is this ready for a final review and merge?

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

WORKSPACE

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

narendasan · 2020-12-11T21:55:01Z

WORKSPACE

    build_file = "@//third_party/tensorrt/archive:BUILD",
-    sha256 = "c7d73b2585b18aae68b740249efa8c8ba5ae852abe9a023720595432a8eb4efd",
-    strip_prefix = "TensorRT-7.0.0.11"
+    sha256 = "818622c7bccfdb0fff362cdd65dc42af4502dcb24e045eb911a4132e8d40a66c",


I think this sha is incorrect. I have been getting this 8def6b03b0c8c3751f560df21b3e99668ae05aab5140b1d38b8e51e4a0ffbbb8

thanks. Fixed it

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

narendasan · 2020-12-12T01:09:16Z

README.md

- cuDNN 7.6.5 (by default, cuDNN 8 supported with compatable PyTorch build)
- TensorRT 7.0.0 (by default, TensorRT 7.1 supported with compatable PyTorch build)
+- Bazel 3.7.0
+- Libtorch 1.7.0 (built with CUDA 11.0)


There is now a PyTorch 1.7.1, so lets bump to that.

narendasan · 2020-12-12T01:09:30Z

WORKSPACE

-    urls = ["https://download.pytorch.org/libtorch/cu102/libtorch-cxx11-abi-shared-with-deps-1.6.0.zip"],
-    sha256 = "fded948bd2dbee625cee33ebbd4843a69496729389e0200a90fbb667cdaeeb69"
+    sha256 = "656db919c00e99dac81bc21598845ba9231e57cbc8e1570bea017dfb9298236d",
+    urls = ["https://download.pytorch.org/libtorch/cu110/libtorch-cxx11-abi-shared-with-deps-1.7.0%2Bcu110.zip"],


Lets move to pytorch 1.7.1

narendasan · 2020-12-12T01:09:58Z

py/setup.py

@@ -204,7 +204,7 @@ def run(self):
      long_description=long_description,
      ext_modules=ext_modules,
      install_requires=[
-          'torch==1.6.0',
+          'torch==1.7.0',


Torch 1.7.1

narendasan · 2020-12-12T01:16:24Z

tests/py/requirements.txt

torchvision 0.8.2

peri044 · 2020-12-12T01:47:44Z

@narendasan Updated to pytorch 1.7.1 and torchvision 0.8.2

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

narendasan

Awesome LGTM!

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

peri044 force-pushed the pytorch_update branch from 06972cd to d848676 Compare November 17, 2020 05:22

github-actions bot approved these changes Nov 17, 2020

View reviewed changes

peri044 requested a review from narendasan November 17, 2020 05:28

github-actions bot approved these changes Nov 17, 2020

View reviewed changes

peri044 force-pushed the pytorch_update branch from d848676 to 3ecf5d0 Compare November 17, 2020 08:35

github-actions bot approved these changes Nov 17, 2020

View reviewed changes

narendasan reviewed Nov 17, 2020

View reviewed changes

peri044 force-pushed the pytorch_update branch from 3ecf5d0 to 217413e Compare November 18, 2020 00:51

github-actions bot added component: api [Python] Issues re: Python API component: api [C++] Issues re: C++ API labels Nov 18, 2020

github-actions bot approved these changes Nov 18, 2020

View reviewed changes

peri044 force-pushed the pytorch_update branch from 217413e to 8bee7b8 Compare November 21, 2020 03:06

github-actions bot approved these changes Nov 23, 2020

View reviewed changes

peri044 added 3 commits December 8, 2020 18:32

Update cudnn and TensorRT versions to latest

01baec2

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

Update dilation/group settings in conv/deconv layers

74eb616

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

Merge branch 'master' into pytorch_update

527ad76

github-actions bot approved these changes Dec 9, 2020

View reviewed changes

Update TRT version in README.md

b025b23

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Dec 9, 2020

View reviewed changes

narendasan requested changes Dec 10, 2020

View reviewed changes

WORKSPACE Show resolved Hide resolved

WORKSPACE Show resolved Hide resolved

WORKSPACE Outdated Show resolved Hide resolved

Update sha for libraries

7646265

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Dec 10, 2020

View reviewed changes

narendasan reviewed Dec 11, 2020

View reviewed changes

Fix sha256 for TRT 7.2 package

5d71867

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Dec 11, 2020

View reviewed changes

github-actions bot approved these changes Dec 12, 2020

View reviewed changes

narendasan reviewed Dec 12, 2020

View reviewed changes

tests/py/requirements.txt Outdated

torchvision==0.8.0

Copy link

Collaborator

narendasan Dec 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

torchvision 0.8.2

Pytorch 1.7.1 update

1ce3e4f

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Dec 12, 2020

View reviewed changes

narendasan self-requested a review December 14, 2020 21:19

narendasan approved these changes Dec 14, 2020

View reviewed changes

github-actions bot approved these changes Dec 14, 2020

View reviewed changes

narendasan merged commit 960d338 into master Dec 14, 2020

narendasan deleted the pytorch_update branch December 14, 2020 21:24

Pytorch 1.7 update API changes #225

Pytorch 1.7 update API changes #225

Uh oh!

Conversation

peri044 commented Nov 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Checklist:

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

narendasan commented Nov 17, 2020

Uh oh!

narendasan commented Nov 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

narendasan commented Nov 17, 2020

Uh oh!

narendasan commented Nov 17, 2020

Uh oh!

narendasan commented Nov 17, 2020

Uh oh!

narendasan commented Nov 17, 2020

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

narendasan commented Dec 8, 2020

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

peri044 commented Nov 17, 2020 •

edited

Loading

narendasan commented Nov 17, 2020 •

edited

Loading