Skip to content

fix deconv with groups > 1 #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2020
Merged

fix deconv with groups > 1 #238

merged 2 commits into from
Dec 8, 2020

Conversation

uni19
Copy link
Contributor

@uni19 uni19 commented Nov 24, 2020 •
edited
Loading

Description

fix deconv with groups > 1
Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@uni19
fix deconv with groups > 1
e994354 
Signed-off-by: uni19 <csljxing@gmail.com>
@narendasan narendasan requested a review from peri044 November 30, 2020 17:12
@narendasan narendasan added the component: converters Issues re: Specific op converters label Nov 30, 2020
peri044
peri044 requested changes Dec 5, 2020
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted my comment. The code LGTM.

@uni19
add comments
b696497 
Signed-off-by: uni19 <csljxing@gmail.com>
@narendasan narendasan requested a review from peri044 December 7, 2020 22:04
narendasan
narendasan approved these changes Dec 7, 2020
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @peri044 can you take a look and see if the comments are good for you?

@peri044
Copy link
Collaborator

peri044 commented Dec 8, 2020

LGTM

@narendasan narendasan merged commit 91bf074 into pytorch:master Dec 8, 2020
@uni19 uni19 deleted the fix_deconv branch December 10, 2020 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@peri044 peri044 peri044 approved these changes

Assignees
No one assigned
Labels
component: converters Issues re: Specific op converters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uni19 @peri044 @narendasan