Skip to content

feat: support aten.sort dynamo converter #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2023
Merged

feat: support aten.sort dynamo converter #2514

merged 1 commit into from
Dec 12, 2023

Conversation

zewenli98
Copy link
Contributor

Description

Support aten.sort dynamo converter.

Fixes #2508

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests labels Dec 5, 2023
@github-actions github-actions bot requested a review from peri044 December 5, 2023 02:08
@zewenli98 zewenli98 requested a review from gs-olive December 5, 2023 02:08
This was referenced Dec 5, 2023
Closed
Open
gs-olive
gs-olive approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@zewenli98 zewenli98 force-pushed the sort_dynamo_converter branch from f0f0aef to 74aad79 Compare December 11, 2023 23:16
@zewenli98 zewenli98 merged commit 2f569c3 into pytorch:main Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 Awaiting requested review from peri044

1 more reviewer

@gs-olive gs-olive gs-olive approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aten.sort
3 participants
@zewenli98 @gs-olive @facebook-github-bot