Skip to content

chore: enable DS support for converters #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 107 commits into from
May 22, 2024
Merged

chore: enable DS support for converters #2775

merged 107 commits into from
May 22, 2024

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Apr 23, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

peri044 added 30 commits October 3, 2023 11:55
@peri044
chore: Switch to new export apis
d06c74a 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: rebase with main
47e0997 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
Merge branch 'main' into export_2.2
fd29fe0
@peri044
feat: Add support for dynamic shapes and remove constraints API
ad3b031 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: add dynamic shape support for certain converters
1582b72 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: minor updates
4d01545 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: updates
6731a57 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: rebase with main
a8a194b 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: add sym int converter
0b60aae 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
feat: Replace the existing shape propagation with symbolic shape prop…
634612f 
…agation

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: fix imports
93edba4 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: fix imports
7ad9272 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: updates
f444d54 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: change device calls
6e5c582 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: fix metadata check
83791f8 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: rebase with main
8375996
@peri044
Merge branch 'main' into dyn_2.2
aba91fa
@peri044
chore: minor fixes
16394d9
@peri044
chore: Add sym_size converter tests
b9a7ccd
@peri044
chore: Update test utilities
15cc643
@peri044
chore: add testcase for sym_size.int
5234d74
@peri044
Merge branch 'main' into dyn_2.2
fd2dae1
@peri044
chore: revert output type change
51e8bb7
@peri044
chore: add update_metadata utility
19c3fad
@peri044
chore: change debug to warning if the graph does not have metadata
ed48551
@peri044
feat: add lowering passes to support dynamic shapes for torch.compile
18b7e11
@peri044
chore: add test case
3a39d27
@peri044
chore: add view test case
abb2677
@peri044
chore: gpt2 changes + linting
9aff04b
@peri044
chore: gpt2 changes + linting
440fcd5
@peri044 peri044 requested review from gs-olive and narendasan and removed request for apbose May 14, 2024 17:26
peri044
peri044 commented May 15, 2024
View reviewed changes
narendasan
narendasan reviewed May 15, 2024
View reviewed changes
@peri044 peri044 changed the base branch from dyn_validator to release/2.3 May 16, 2024 21:53
narendasan
narendasan reviewed May 17, 2024
View reviewed changes
gs-olive
gs-olive reviewed May 17, 2024
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great - just added a few comments and suggestions

@peri044 peri044 merged commit 47b2902 into release/2.3 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan left review comments

@gs-olive gs-olive gs-olive left review comments

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: runtime component: tests Issues re: Tests component: torch_compile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peri044 @narendasan @gs-olive @facebook-github-bot