-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
empty_stride decomposition #2859
Conversation
41f0324
to
1360961
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/lowering/test_decompositions.py 2024-06-06 22:53:37.987181+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/lowering/test_decompositions.py 2024-06-06 22:55:54.420669+00:00
@@ -869,29 +869,29 @@
DECIMALS_OF_AGREEMENT,
f"Select_scatter TRT outputs don't match with the original model.",
)
empty_ops = [
- (
- "empty_stride_one_dimension_firstcase",
- [5, 5],
- [1, 2],
- None,
- ),
- (
- "empty_stride_two_dimension_secondcase",
- [5, 5],
- [2, 2],
- None,
- ),
- (
- "empty_three_dimension",
- [8, 8, 8],
- [1, 2, 3],
- torch.int32,
- ),
- ]
+ (
+ "empty_stride_one_dimension_firstcase",
+ [5, 5],
+ [1, 2],
+ None,
+ ),
+ (
+ "empty_stride_two_dimension_secondcase",
+ [5, 5],
+ [2, 2],
+ None,
+ ),
+ (
+ "empty_three_dimension",
+ [8, 8, 8],
+ [1, 2, 3],
+ torch.int32,
+ ),
+ ]
@parameterized.expand(
[(empty_op[0], empty_op[1], empty_op[2], empty_op[3]) for empty_op in empty_ops]
)
def test_empty_stride(self, _, shape_or_input, stride, data_type):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just need a minor fix
from torch.testing._internal.common_utils import TestCase, run_tests | ||
from parameterized import parameterized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicated as line 3
1360961
to
aeae9b3
Compare
ec15e77
to
e296688
Compare
adding test cases and correcting empty__stride decomposition
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: