Skip to content

Conversation

lanluo-nvidia
Copy link
Collaborator

@lanluo-nvidia lanluo-nvidia commented Jul 26, 2024

Description

fix the build name issue:
BUILD_VERSION: this is the our torch_tensorrt version
PYTORCH_VERSION: this is the torch version

most of the time torch_tensorrt and torch version are the same
but in case in release2.3: BUILD_VERSION is 2.3.0 PYTORCH_VERSION:2.3.1

hence here make the change so that it is clear.

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia added ciflow/binaries/all Build for all Python Versions build-release-artifacts Build the release artifacts labels Jul 26, 2024
@lanluo-nvidia lanluo-nvidia self-assigned this Jul 26, 2024
Copy link

pytorch-bot bot commented Jul 26, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review July 26, 2024 04:23
@lanluo-nvidia lanluo-nvidia requested review from apbose and peri044 July 26, 2024 04:23
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lanluo-nvidia
Copy link
Collaborator Author

LGTM. A question Is the BUILD_VERSION flag coming from https://github.com/pytorch/TensorRT/blob/a55c13931924e1638ba3802fccc72b4eea93d261/py/ci/build_whl.sh ?

All the files except soname_excludes.params under
py/ci/* are no longer being used, it is for old CI system.

@lanluo-nvidia lanluo-nvidia merged commit 77278fe into release/2.4 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-release-artifacts Build the release artifacts ciflow/binaries/all Build for all Python Versions cla signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants