Skip to content

Fix unused variable out warning #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2021
Merged

Fix unused variable out warning #314

merged 3 commits into from
Feb 4, 2021

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Feb 3, 2021

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

Description

Fix unused variable warning in clamp

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler labels Feb 3, 2021
@peri044 peri044 requested a review from narendasan February 3, 2021 07:36
github-actions[bot]
github-actions bot requested changes Feb 3, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/workspace/tests/core/conversion/converters/test_element_wise.cpp b/tmp/changes.txt
index 4b2fe9c..5431e9a 100644
--- a/workspace/tests/core/conversion/converters/test_element_wise.cpp
+++ b/tmp/changes.txt
@@ -172,117 +172,117 @@ TEST(Converters, ATenNeScalarConvertsCorrectly) {
  pointwise_test_helper(graph, true, false, {3, 4, 2});
  ;

-TEST(Converters, ATenClampMinConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenClampMinConvertsCorrectly) {
+    const auto graph = R"IR(
    graph(%x.1 : Tensor):
            %2 : int = prim::Constant[value=-2]()
            %3 : None = prim::Constant()
            %4 : Tensor = aten::clamp(%x.1, %2, %3)
            return (%4))IR";
-  pointwise_test_helper(graph, true);
-}
+    pointwise_test_helper(graph, true);
+  }

-TEST(Converters, ATenClampMaxConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenClampMaxConvertsCorrectly) {
+    const auto graph = R"IR(
    graph(%x.1 : Tensor):
            %2 : int = prim::Constant[value=3]()
            %3 : None = prim::Constant()
            %4 : Tensor = aten::clamp(%x.1, %3, %2)
            return (%4))IR";
-  pointwise_test_helper(graph, true);
-}
+    pointwise_test_helper(graph, true);
+  }

-TEST(Converters, ATenClampMinMaxConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenClampMinMaxConvertsCorrectly) {
+    const auto graph = R"IR(
    graph(%x.1 : Tensor):
            %2 : int = prim::Constant[value=3]()
            %3 : int = prim::Constant[value=-2]()
            %4 : Tensor = aten::clamp(%x.1, %3, %2)
            return (%4))IR";
-  pointwise_test_helper(graph, true);
-}
+    pointwise_test_helper(graph, true);
+  }

-TEST(Converters, ATenGreaterThanConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenGreaterThanConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor, %1 : Tensor):
        %2 : Tensor = aten::gt(%0, %1)
        return (%2))IR";
-  pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+    pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+  }

-TEST(Converters, ATenGreaterThanScalarConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenGreaterThanScalarConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor):
        %scalar : float = prim::Constant[value=3]()
        %2 : Tensor = aten::gt(%0, %scalar)
        return (%2))IR";
-  pointwise_test_helper(graph, true, false, {5, 5});
-}
+    pointwise_test_helper(graph, true, false, {5, 5});
+  }

-TEST(Converters, ATenLessThanConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenLessThanConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor, %1 : Tensor):
        %2 : Tensor = aten::lt(%0, %1)
        return (%2))IR";
-  pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+    pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+  }

-TEST(Converters, ATenLessThanScalarConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenLessThanScalarConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor):
        %scalar : float = prim::Constant[value=3]()
        %2 : Tensor = aten::lt(%0, %scalar)
        return (%2))IR";
-  pointwise_test_helper(graph, true, false, {5, 5});
-}
+    pointwise_test_helper(graph, true, false, {5, 5});
+  }

-TEST(Converters, ATenEqualConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenEqualConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor, %1 : Tensor):
        %2 : Tensor = aten::eq(%0, %1)
        return (%2))IR";
-  pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+    pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+  }

-TEST(Converters, ATenEqualScalarConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenEqualScalarConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor):
        %scalar : float = prim::Constant[value=3]()
        %2 : Tensor = aten::eq(%0, %scalar)
        return (%2))IR";
-  pointwise_test_helper(graph, true, false, {5, 5});
-}
+    pointwise_test_helper(graph, true, false, {5, 5});
+  }

-TEST(Converters, ATenGEConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenGEConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor, %1 : Tensor):
        %2 : Tensor = aten::ge(%0, %1)
        return (%2))IR";
-  pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+    pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+  }

-TEST(Converters, ATenGEScalarConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenGEScalarConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor):
        %scalar : float = prim::Constant[value=3]()
        %2 : Tensor = aten::ge(%0, %scalar)
        return (%2))IR";
-  pointwise_test_helper(graph, true, false, {5, 5});
-}
+    pointwise_test_helper(graph, true, false, {5, 5});
+  }

-TEST(Converters, ATenLEConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenLEConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor, %1 : Tensor):
        %2 : Tensor = aten::le(%0, %1)
        return (%2))IR";
-  pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+    pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+  }

-TEST(Converters, ATenLEScalarConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenLEScalarConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor):
        %scalar : float = prim::Constant[value=3]()
        %2 : Tensor = aten::le(%0, %scalar)
        return (%2))IR";
-  pointwise_test_helper(graph, true, false, {5, 5});
-}
+    pointwise_test_helper(graph, true, false, {5, 5});
+  }
ERROR: Some files do not conform to style guidelines

github-actions[bot]
github-actions bot approved these changes Feb 3, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Feb 3, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot requested changes Feb 3, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/workspace/tests/core/conversion/converters/test_element_wise.cpp b/tmp/changes.txt
index 4b2fe9c..5431e9a 100644
--- a/workspace/tests/core/conversion/converters/test_element_wise.cpp
+++ b/tmp/changes.txt
@@ -172,117 +172,117 @@ TEST(Converters, ATenNeScalarConvertsCorrectly) {
  pointwise_test_helper(graph, true, false, {3, 4, 2});
  ;

-TEST(Converters, ATenClampMinConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenClampMinConvertsCorrectly) {
+    const auto graph = R"IR(
    graph(%x.1 : Tensor):
            %2 : int = prim::Constant[value=-2]()
            %3 : None = prim::Constant()
            %4 : Tensor = aten::clamp(%x.1, %2, %3)
            return (%4))IR";
-  pointwise_test_helper(graph, true);
-}
+    pointwise_test_helper(graph, true);
+  }

-TEST(Converters, ATenClampMaxConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenClampMaxConvertsCorrectly) {
+    const auto graph = R"IR(
    graph(%x.1 : Tensor):
            %2 : int = prim::Constant[value=3]()
            %3 : None = prim::Constant()
            %4 : Tensor = aten::clamp(%x.1, %3, %2)
            return (%4))IR";
-  pointwise_test_helper(graph, true);
-}
+    pointwise_test_helper(graph, true);
+  }

-TEST(Converters, ATenClampMinMaxConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenClampMinMaxConvertsCorrectly) {
+    const auto graph = R"IR(
    graph(%x.1 : Tensor):
            %2 : int = prim::Constant[value=3]()
            %3 : int = prim::Constant[value=-2]()
            %4 : Tensor = aten::clamp(%x.1, %3, %2)
            return (%4))IR";
-  pointwise_test_helper(graph, true);
-}
+    pointwise_test_helper(graph, true);
+  }

-TEST(Converters, ATenGreaterThanConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenGreaterThanConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor, %1 : Tensor):
        %2 : Tensor = aten::gt(%0, %1)
        return (%2))IR";
-  pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+    pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+  }

-TEST(Converters, ATenGreaterThanScalarConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenGreaterThanScalarConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor):
        %scalar : float = prim::Constant[value=3]()
        %2 : Tensor = aten::gt(%0, %scalar)
        return (%2))IR";
-  pointwise_test_helper(graph, true, false, {5, 5});
-}
+    pointwise_test_helper(graph, true, false, {5, 5});
+  }

-TEST(Converters, ATenLessThanConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenLessThanConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor, %1 : Tensor):
        %2 : Tensor = aten::lt(%0, %1)
        return (%2))IR";
-  pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+    pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+  }

-TEST(Converters, ATenLessThanScalarConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenLessThanScalarConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor):
        %scalar : float = prim::Constant[value=3]()
        %2 : Tensor = aten::lt(%0, %scalar)
        return (%2))IR";
-  pointwise_test_helper(graph, true, false, {5, 5});
-}
+    pointwise_test_helper(graph, true, false, {5, 5});
+  }

-TEST(Converters, ATenEqualConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenEqualConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor, %1 : Tensor):
        %2 : Tensor = aten::eq(%0, %1)
        return (%2))IR";
-  pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+    pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+  }

-TEST(Converters, ATenEqualScalarConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenEqualScalarConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor):
        %scalar : float = prim::Constant[value=3]()
        %2 : Tensor = aten::eq(%0, %scalar)
        return (%2))IR";
-  pointwise_test_helper(graph, true, false, {5, 5});
-}
+    pointwise_test_helper(graph, true, false, {5, 5});
+  }

-TEST(Converters, ATenGEConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenGEConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor, %1 : Tensor):
        %2 : Tensor = aten::ge(%0, %1)
        return (%2))IR";
-  pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+    pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+  }

-TEST(Converters, ATenGEScalarConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenGEScalarConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor):
        %scalar : float = prim::Constant[value=3]()
        %2 : Tensor = aten::ge(%0, %scalar)
        return (%2))IR";
-  pointwise_test_helper(graph, true, false, {5, 5});
-}
+    pointwise_test_helper(graph, true, false, {5, 5});
+  }

-TEST(Converters, ATenLEConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenLEConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor, %1 : Tensor):
        %2 : Tensor = aten::le(%0, %1)
        return (%2))IR";
-  pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
-}
+    pointwise_test_helper(graph, false, false, {5, 5}, {5, 5});
+  }

-TEST(Converters, ATenLEScalarConvertsCorrectly) {
-  const auto graph = R"IR(
+  TEST(Converters, ATenLEScalarConvertsCorrectly) {
+    const auto graph = R"IR(
      graph(%0 : Tensor):
        %scalar : float = prim::Constant[value=3]()
        %2 : Tensor = aten::le(%0, %scalar)
        return (%2))IR";
-  pointwise_test_helper(graph, true, false, {5, 5});
-}
+    pointwise_test_helper(graph, true, false, {5, 5});
+  }
ERROR: Some files do not conform to style guidelines

narendasan
narendasan approved these changes Feb 4, 2021
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will add linting and merge

@github-actions github-actions bot added the component: tests Issues re: Tests label Feb 4, 2021
github-actions[bot]
github-actions bot approved these changes Feb 4, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Feb 4, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

peri044 and others added 3 commits February 3, 2021 17:51
@peri044 @narendasan
Fix unused variable out warning
0f48708 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@narendasan
refactor(tests): Apply linting to pointwise tests
bc4aeb7 
Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
@narendasan
fix(tests): Fix broken elementwise tests
22ed944 
Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
github-actions[bot]
github-actions bot approved these changes Feb 4, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Feb 4, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@narendasan narendasan merged commit 4903010 into master Feb 4, 2021
@narendasan narendasan deleted the clamp branch February 4, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peri044 @narendasan