-
Notifications
You must be signed in to change notification settings - Fork 372
Add a new API to disable TF32 #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/cpp/trtorchc/main.cpp b/tmp/changes.txt
index 61cc4f9..93dbe33 100644
--- a/workspace/cpp/trtorchc/main.cpp
+++ b/tmp/changes.txt
@@ -164,10 +164,7 @@ int main(int argc, char** argv) {
{"allow-gpu-fallback"});
args::Flag disable_tf32(
- parser,
- "disable-tf32",
- "Prevent Float32 layers from using the TF32 data format",
- {"disable-tf32"});
+ parser, "disable-tf32", "Prevent Float32 layers from using the TF32 data format", {"disable-tf32"});
args::ValueFlag<std::string> op_precision(
parser,
ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/cpp/trtorchc/main.cpp b/tmp/changes.txt
index 61cc4f9..93dbe33 100644
--- a/workspace/cpp/trtorchc/main.cpp
+++ b/tmp/changes.txt
@@ -164,10 +164,7 @@ int main(int argc, char** argv) {
{"allow-gpu-fallback"});
args::Flag disable_tf32(
- parser,
- "disable-tf32",
- "Prevent Float32 layers from using the TF32 data format",
- {"disable-tf32"});
+ parser, "disable-tf32", "Prevent Float32 layers from using the TF32 data format", {"disable-tf32"});
args::ValueFlag<std::string> op_precision(
parser,
ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/cpp/trtorchc/main.cpp b/tmp/changes.txt
index 61cc4f9..93dbe33 100644
--- a/workspace/cpp/trtorchc/main.cpp
+++ b/tmp/changes.txt
@@ -164,10 +164,7 @@ int main(int argc, char** argv) {
{"allow-gpu-fallback"});
args::Flag disable_tf32(
- parser,
- "disable-tf32",
- "Prevent Float32 layers from using the TF32 data format",
- {"disable-tf32"});
+ parser, "disable-tf32", "Prevent Float32 layers from using the TF32 data format", {"disable-tf32"});
args::ValueFlag<std::string> op_precision(
parser,
ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
LGTM |
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
Description
On Ampere TF32 is the default FP32 format. This PR adds support to disable TF32 and use the standard FP32 format.
Fixes #247
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: