Skip to content

feat: revert linear converter #3703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2025
Merged

feat: revert linear converter #3703

merged 2 commits into from
Jul 22, 2025

Conversation

zewenli98
Copy link
Collaborator

Description

This PR reverts back linear converter because it shows perf improvements on BERT in fp16 if we take linear op as a whole. I didn't observe significant improvements on BERT fp32 though.

Fixes #3702

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Jul 22, 2025
@pytorch-bot pytorch-bot bot added the ci-no-td label Jul 22, 2025
@github-actions github-actions bot added component: tests Issues re: Tests component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jul 22, 2025
peri044
peri044 approved these changes Jul 22, 2025
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cehongwang
cehongwang approved these changes Jul 22, 2025
View reviewed changes
Copy link
Collaborator

@cehongwang cehongwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zewenli98 zewenli98 merged commit 92a6908 into main Jul 22, 2025
88 of 89 checks passed
This was referenced Jul 24, 2025
Closed
Closed
@zewenli98 zewenli98 mentioned this pull request Jul 31, 2025
Merged
zewenli98 added a commit that referenced this pull request Aug 1, 2025
@zewenli98
Cherrypick #3703 for release/2.8 (#3735)
7fb0d3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@cehongwang cehongwang cehongwang approved these changes

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@zewenli98 zewenli98

Labels
ci-no-td cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] perf gap reduce on BERT
4 participants
@zewenli98 @peri044 @cehongwang @facebook-github-bot