Skip to content

Add aten.transpose support. #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Add aten.transpose support. #374

merged 1 commit into from
Feb 25, 2021

Conversation

chengyute
Copy link
Contributor

@chengyute chengyute commented Feb 24, 2021

Description

Add support for aten::transpose in shuffle converter.
Function Schema:
aten::transpose.int(Tensor(a) self, int dim0, int dim1) -> (Tensor(a))

Fixes # 275

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@chengyute chengyute requested a review from narendasan February 24, 2021 16:21
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests labels Feb 24, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@narendasan
Copy link
Collaborator

@chengyute you need to sign your commit using the same email attached to your github in addition to your NVIDIA email git commit --amend --no-edit --signoff

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me

@chengyute chengyute force-pushed the yutec_aten_tranaspose branch from 2a4c597 to 6f2166e Compare February 24, 2021 23:44
Signed-off-by: Yu-Te Cheng <chengyute@gmail.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@chengyute
Copy link
Contributor Author

Done. @narendasan , you can merge it.

@narendasan narendasan added the merge ready PR has all comments addressed, ready for final integration testing and merge label Feb 25, 2021
@narendasan narendasan merged commit 88f2a94 into master Feb 25, 2021
@narendasan narendasan deleted the yutec_aten_tranaspose branch February 24, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests merge ready PR has all comments addressed, ready for final integration testing and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants