-
Notifications
You must be signed in to change notification settings - Fork 371
fix(//core/conversion/conversionctx): Fix memory leak in conversionctx #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
context engine serialization h/t: @SakodaShintaro Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- /workspace/py/trtorch/_compiler.py (original)
+++ /workspace/py/trtorch/_compiler.py (reformatted)
@@ -157,5 +157,6 @@
build_info = "TRTorch Version: " + str(__version__) + '\n' + build_info
return build_info
+
def set_device(gpu_id):
trtorch._C.set_device(gpu_id)
Reformatting /workspace/py/trtorch/_compile_spec.py
Reformatting /workspace/py/trtorch/_types.py
Reformatting /workspace/py/trtorch/_compiler.py
Reformatting /workspace/py/trtorch/logging.py
Reformatting /workspace/py/trtorch/__init__.py
Reformatting /workspace/py/setup.py
ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
Reformatting /workspace/py/trtorch/_compile_spec.py
Reformatting /workspace/py/trtorch/_types.py
Reformatting /workspace/py/trtorch/_compiler.py
Reformatting /workspace/py/trtorch/logging.py
Reformatting /workspace/py/trtorch/__init__.py
Reformatting /workspace/py/setup.py
Reformatting /workspace/docsrc/conf.py
Reformatting /workspace/tests/modules/hub.py
--- /workspace/tests/py/test_multi_gpu.py (original)
+++ /workspace/tests/py/test_multi_gpu.py (reformatted)
@@ -5,7 +5,9 @@
from model_test_case import ModelTestCase
+
class TestMultiGpuSwitching(ModelTestCase):
+
def setUp(self):
if torch.cuda.device_count() < 2:
self.fail("Test is not relevant for this platform since number of available CUDA devices is less than 2")
@@ -55,11 +57,13 @@
trtorch.set_device(0)
self.assertTrue(same < 2e-3)
+
def test_suite():
suite = unittest.TestSuite()
suite.addTest(TestMultiGpuSwitching.parametrize(TestMultiGpuSwitching, model=models.resnet18(pretrained=True)))
return suite
+
suite = test_suite()
Reformatting /workspace/tests/py/model_test_case.py
Reformatting /workspace/tests/py/test_api_dla.py
Reformatting /workspace/tests/py/test_api.py
Reformatting /workspace/tests/py/test_multi_gpu.py
Reformatting /workspace/tests/py/test_to_backend_api.py
ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
Description
Fixes a memory leak where the
IHostMemory
container for the produced serialized engine after conversion is not destructed properly.h/t: @SakodaShintaro
Fixes #375
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: