Skip to content

Conversation

borisfom
Copy link
Collaborator

…tive pooling

Signed-off-by: Boris Fomitchev bfomitchev@nvidia.com

Description

Added support for 1d convolutions.
Also:
Fixed 1d case for batch normalization
Included a fix for prim::ListConstruct when arg is a Tuple (apparently valid use case)
Refactored pooling
1D pooling and special case for adaptive pooling -> global pooling

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@borisfom borisfom requested review from narendasan and peri044 April 24, 2021 01:19
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think everything looks almost ready to go. It seems like you are still returning nullptr for the padding helper though you intended to pass through the original tensor. Also changing some of the error checking macros to ones that would be more relevant for what is being done

…tive pooling

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@narendasan narendasan merged commit c189747 into pytorch:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants