-
Notifications
You must be signed in to change notification settings - Fork 372
Implemented 1D conv, refactored pooling, 1D and special case for adap… #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think everything looks almost ready to go. It seems like you are still returning nullptr for the padding helper though you intended to pass through the original tensor. Also changing some of the error checking macros to ones that would be more relevant for what is being done
…tive pooling Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…tive pooling
Signed-off-by: Boris Fomitchev bfomitchev@nvidia.com
Description
Added support for 1d convolutions.
Also:
Fixed 1d case for batch normalization
Included a fix for prim::ListConstruct when arg is a Tuple (apparently valid use case)
Refactored pooling
1D pooling and special case for adaptive pooling -> global pooling
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: