Skip to content

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Aug 9, 2021

Description

Fix TRT 8 engine capability flags in trtorchc

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added component: torchtrtc documentation Improvements or additions to documentation labels Aug 9, 2021
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044 peri044 requested a review from narendasan August 9, 2021 18:49
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/workspace/core/runtime/TRTEngine.cpp b/tmp/changes.txt
index 9d579b2..5610cae 100644
--- a/workspace/core/runtime/TRTEngine.cpp
+++ b/tmp/changes.txt
@@ -45,7 +45,8 @@ TRTEngine::TRTEngine(std::string mod_name, std::string serialized_engine, CudaDe

  name = slugify(mod_name) + "_engine";

-  cuda_engine = std::shared_ptr<nvinfer1::ICudaEngine>(rt->deserializeCudaEngine(serialized_engine.c_str(), serialized_engine.size()));
+  cuda_engine = std::shared_ptr<nvinfer1::ICudaEngine>(
+      rt->deserializeCudaEngine(serialized_engine.c_str(), serialized_engine.size()));
  TRTORCH_CHECK((cuda_engine != nullptr), "Unable to deserialize the TensorRT engine");

  exec_ctx = std::shared_ptr<nvinfer1::IExecutionContext>(cuda_engine->createExecutionContext());
ERROR: Some files do not conform to style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/workspace/core/runtime/TRTEngine.cpp b/tmp/changes.txt
index 9d579b2..5610cae 100644
--- a/workspace/core/runtime/TRTEngine.cpp
+++ b/tmp/changes.txt
@@ -45,7 +45,8 @@ TRTEngine::TRTEngine(std::string mod_name, std::string serialized_engine, CudaDe

  name = slugify(mod_name) + "_engine";

-  cuda_engine = std::shared_ptr<nvinfer1::ICudaEngine>(rt->deserializeCudaEngine(serialized_engine.c_str(), serialized_engine.size()));
+  cuda_engine = std::shared_ptr<nvinfer1::ICudaEngine>(
+      rt->deserializeCudaEngine(serialized_engine.c_str(), serialized_engine.size()));
  TRTORCH_CHECK((cuda_engine != nullptr), "Unable to deserialize the TensorRT engine");

  exec_ctx = std::shared_ptr<nvinfer1::IExecutionContext>(cuda_engine->createExecutionContext());
ERROR: Some files do not conform to style guidelines

@github-actions github-actions bot added component: core Issues re: The core compiler component: runtime labels Aug 9, 2021
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@narendasan narendasan merged commit 8581fd9 into master Aug 9, 2021
@narendasan narendasan deleted the tensorrt_8_update branch August 9, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core Issues re: The core compiler component: runtime component: torchtrtc documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants