-
Notifications
You must be signed in to change notification settings - Fork 372
fix: Fix TRT8 engine capability flags #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/core/runtime/TRTEngine.cpp b/tmp/changes.txt
index 9d579b2..5610cae 100644
--- a/workspace/core/runtime/TRTEngine.cpp
+++ b/tmp/changes.txt
@@ -45,7 +45,8 @@ TRTEngine::TRTEngine(std::string mod_name, std::string serialized_engine, CudaDe
name = slugify(mod_name) + "_engine";
- cuda_engine = std::shared_ptr<nvinfer1::ICudaEngine>(rt->deserializeCudaEngine(serialized_engine.c_str(), serialized_engine.size()));
+ cuda_engine = std::shared_ptr<nvinfer1::ICudaEngine>(
+ rt->deserializeCudaEngine(serialized_engine.c_str(), serialized_engine.size()));
TRTORCH_CHECK((cuda_engine != nullptr), "Unable to deserialize the TensorRT engine");
exec_ctx = std::shared_ptr<nvinfer1::IExecutionContext>(cuda_engine->createExecutionContext());
ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/core/runtime/TRTEngine.cpp b/tmp/changes.txt
index 9d579b2..5610cae 100644
--- a/workspace/core/runtime/TRTEngine.cpp
+++ b/tmp/changes.txt
@@ -45,7 +45,8 @@ TRTEngine::TRTEngine(std::string mod_name, std::string serialized_engine, CudaDe
name = slugify(mod_name) + "_engine";
- cuda_engine = std::shared_ptr<nvinfer1::ICudaEngine>(rt->deserializeCudaEngine(serialized_engine.c_str(), serialized_engine.size()));
+ cuda_engine = std::shared_ptr<nvinfer1::ICudaEngine>(
+ rt->deserializeCudaEngine(serialized_engine.c_str(), serialized_engine.size()));
TRTORCH_CHECK((cuda_engine != nullptr), "Unable to deserialize the TensorRT engine");
exec_ctx = std::shared_ptr<nvinfer1::IExecutionContext>(cuda_engine->createExecutionContext());
ERROR: Some files do not conform to style guidelines
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
Description
Fix TRT 8 engine capability flags in trtorchc
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: